Removing Limit and Offset from read queries #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsetgo
added
documentation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title: Removing Limit and Offset from read queries
The current implementation of our read queries includes limit and offset parameters. While these parameters can be useful in certain scenarios, they can also lead to performance issues when dealing with large datasets.
This Pull Request removes the limit and offset parameters from our read queries. This change will help improve the performance of our queries significantly, especially when dealing with large datasets.
The removal of these parameters will not impact the functionality of our queries, as we have other methods in place to handle paging and limiting the number of records returned.
This PR also increases the version of our application as this is a significant change, and updates the coverage reports accordingly.
Overall, this change will make our read queries more efficient and improve the performance of our application.